Create a separate crate for workunit_store #7855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Jun 5, 2019
src/rust/engine/src/lib.rs
Outdated
| @@ -75,6 +77,7 @@ use crate::handles::Handle; | |||
| use crate::scheduler::{ExecutionRequest, RootResult, Scheduler, Session}; | |||
| use crate::tasks::{Rule, Tasks}; | |||
| use crate::types::Types; | |||
| use crate::workunit_store::WorkUnitStore; | |||
There was a problem hiding this comment.
Suggested change
| use crate::workunit_store::WorkUnitStore; | |
| use workunit_store::WorkUnitStore; |
We generally use crate:: to point at things which are defined in this crate, whereas workunit_store is an external crate.
src/rust/engine/src/lib.rs
Outdated
| @@ -51,6 +51,8 @@ use log; | |||
|
|
|||
| use tar_api; | |||
|
|
|||
| use workunit_store; | |||
There was a problem hiding this comment.
I think this line (and the newline after it) can be removed after my suggestion below.
src/rust/engine/src/nodes.rs
Outdated
| @@ -19,6 +19,7 @@ use crate::core::{throw, Failure, Key, Params, TypeId, Value}; | |||
| use crate::externs; | |||
| use crate::selectors; | |||
| use crate::tasks::{self, Intrinsic, Rule}; | |||
| use crate::workunit_store::{WorkUnit, WorkUnitStore}; | |||
There was a problem hiding this comment.
Suggested change
| use crate::workunit_store::{WorkUnit, WorkUnitStore}; | |
| use workunit_store::{WorkUnit, WorkUnitStore}; |
src/rust/engine/src/scheduler.rs
Outdated
| @@ -13,6 +13,7 @@ use futures::future::{self, Future}; | |||
| use crate::context::{Context, Core}; | |||
| use crate::core::{Failure, Params, TypeId, Value}; | |||
| use crate::nodes::{NodeKey, Select, Tracer, Visualizer}; | |||
| use crate::workunit_store::{WorkUnit, WorkUnitStore}; | |||
There was a problem hiding this comment.
Suggested change
| use crate::workunit_store::{WorkUnit, WorkUnitStore}; | |
| use workunit_store::{WorkUnit, WorkUnitStore}; |
blorente
approved these changes
Jun 7, 2019
cattibrie
pushed a commit
to cattibrie/pants
that referenced
this pull request
Jun 19, 2019
We are decoupling `Session` from `WorkUnit` related structure. - Create workunit_store crate - Extract WorkUnit and WorkUnitStore traits from `Session` - Implement `WorkUnitStore` trait for `Session`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are decoupling
SessionfromWorkUnitrelated structure.SessionWorkUnitStoretrait forSession