Fix py-thrift-namespace-clash-check type issue when logging with --no-strict mode
#7864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
changed the title
py-thrift-namespace-clash-check logging issue when using --no-strictpy-thrift-namespace-clash-check type issue when logging with --no-strict mode
stuhood
approved these changes
Jun 6, 2019
|
Some flakes, but merging. |
stuhood
pushed a commit
that referenced
this pull request
Jun 6, 2019
…-no-strict` mode (#7864) ### Problem When running `py-thrift-namespace-clash-check` in Twitter's sandbox with `--no-strict` mode, Pants crashed with the exception: ``` zip_longest argument #1 must support iteration ``` This is because we were trying to log a `NamespaceExtractionError`, and `log()` only understands `Union[str, Tuple[str, str]]`. ### Solution Fix the issue by using `str()` to get the underlying message. Also add an assertion to make sure that we don't introduce this issue again. Once we have MyPy set up, we can remove this assertion.
Eric-Arellano
added a commit
that referenced
this pull request
Jun 6, 2019
…-no-strict` mode (#7864) ### Problem When running `py-thrift-namespace-clash-check` in Twitter's sandbox with `--no-strict` mode, Pants crashed with the exception: ``` zip_longest argument #1 must support iteration ``` This is because we were trying to log a `NamespaceExtractionError`, and `log()` only understands `Union[str, Tuple[str, str]]`. ### Solution Fix the issue by using `str()` to get the underlying message. Also add an assertion to make sure that we don't introduce this issue again. Once we have MyPy set up, we can remove this assertion.
stuhood
pushed a commit
that referenced
this pull request
Jun 7, 2019
…-no-strict` mode (#7864) ### Problem When running `py-thrift-namespace-clash-check` in Twitter's sandbox with `--no-strict` mode, Pants crashed with the exception: ``` zip_longest argument #1 must support iteration ``` This is because we were trying to log a `NamespaceExtractionError`, and `log()` only understands `Union[str, Tuple[str, str]]`. ### Solution Fix the issue by using `str()` to get the underlying message. Also add an assertion to make sure that we don't introduce this issue again. Once we have MyPy set up, we can remove this assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running
py-thrift-namespace-clash-checkin Twitter's sandbox with--no-strictmode, Pants crashed with the exception:This is because we were trying to log a
NamespaceExtractionError, andlog()only understandsUnion[str, Tuple[str, str]].Solution
Fix the issue by using
str()to get the underlying message.Also add an assertion to make sure that we don't introduce this issue again. Once we have MyPy set up, we can remove this assertion.