Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Nailgun failure when the port is not specified #7878
Downstream Twitter tests were failing to compile certain targets with the error message:
This happens when
This ends up resulting in the nailgun code trying to use
Instead, we use Pants' idiom of setting the default to
jsirois left a comment
The commit description seems over the top to me. This is all just the common pattern of using meaningful default param values instead of None plus check in constructor. That central lesson and fix is pretty well obscured by a wall of text.
Eric-Arellano left a comment
Agreed, and very good feedback. Because I hadn't yet run the fix through Twitter tests—and it took a while to figure out how all the pieces fit together—I was retracing my steps as an exercise in reasoning about the correctness of the solution. While useful to me, doesn't mean it's helpful in the PR description. I shortened it quite a bit.
Thanks for the review both!