No longer release a Python 2 wheel or PEX #7888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
requested review from
stuhood,
jsirois,
benjyw,
illicitonion and
blorente
|
Not to merge until Twitter has landed their Python 3 patch, which will hopefully be today or tomorrow. Otherwise all ready for review :) |
benjyw
approved these changes
Jun 17, 2019
For some reason, `check_pants_pex_abi.py` cannot find `./pants.pex`. Maybe, just maybe, this is related..?
* Missing urllib imports * Not redirecting stdout to stderr
There's no more need to parametrize docker_image_name. Removing that flexibility makes the code more explicit and easier to understand.
# Delete this line to force a full CI run for documentation-only changes. SKIP_FULL_CI # Documentation-only change.
stuhood
added a commit
that referenced
this pull request
Jun 22, 2019
### Problem #7888 fixed most of the locations that were expecting particular whl counts, but missed one. ### Solution Fix the last whl count check. ### Result Confirmed that `build-support/bin/release.sh -p` works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will now require Python 3 to run Pants for new releases (1.18.x or greater), per https://groups.google.com/forum/#!topic/pants-devel/-bMRstFtMZU.
Here, we remove Python 2 from all release related code, including:
-2and--py2logic fromrelease.shandpackages.py.