Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer release a Python 2 wheel or PEX #7888

Merged
merged 13 commits into from Jun 21, 2019

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

commented Jun 17, 2019

We will now require Python 3 to run Pants for new releases (1.18.x or greater), per https://groups.google.com/forum/#!topic/pants-devel/-bMRstFtMZU.

Here, we remove Python 2 from all release related code, including:

  • Remove Python 2 wheel building shards.
  • Remove Python 2 UCS 4 Docker image.
  • Remove -2 and --py2 logic from release.sh and packages.py.
  • Remove documentation claiming support for running with Python 2.7.
@Eric-Arellano

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

Not to merge until Twitter has landed their Python 3 patch, which will hopefully be today or tomorrow.

Otherwise all ready for review :)

@benjyw

benjyw approved these changes Jun 17, 2019

Eric-Arellano added some commits Jun 17, 2019

Restore original linux build wheels anchor order to try to fix issue
For some reason, `check_pants_pex_abi.py` cannot find `./pants.pex`. Maybe, just maybe, this is related..?
Fix issues with packages.py
* Missing urllib imports
* Not redirecting stdout to stderr
@ity

ity approved these changes Jun 18, 2019

Copy link
Contributor

left a comment

nice!

Eric-Arellano added some commits Jun 19, 2019

Simplify Docker usage now that we only ever use travis_ci
There's no more need to parametrize docker_image_name. Removing that flexibility makes the code more explicit and easier to understand.
Update documentation to remove mentions of supporting Python 2.7
# Delete this line to force a full CI run for documentation-only changes.
SKIP_FULL_CI  # Documentation-only change.
@ity

ity approved these changes Jun 21, 2019

Copy link
Contributor

left a comment

still lgtm!

@Eric-Arellano Eric-Arellano merged commit 4830e7b into pantsbuild:master Jun 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:remove-py2-release branch Jun 21, 2019

stuhood added a commit that referenced this pull request Jun 22, 2019

Fix the wheel count check for pex building. (#7933)
### Problem

#7888 fixed most of the locations that were expecting particular whl counts, but missed one.

### Solution

Fix the last whl count check.

### Result

Confirmed that `build-support/bin/release.sh -p` works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.