Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Centos7 docker image to allow building Python 3.7 wheels #7892

Merged
merged 7 commits into from Jun 19, 2019

Conversation

Eric-Arellano
Copy link
Contributor

@Eric-Arellano Eric-Arellano commented Jun 18, 2019

Per #7288, we will very soon want to replace usage of Centos6 for Centos7 to pay off tech debt. The other motivation for using Centos7 is that we could start to build Python 3.7 wheels for Linux, meaning that we could ship a Python 3.7 PEX.

This is pre-work for both goals by adding the base Centos7 image, which we will publish to DockerHub.

See https://travis-ci.org/pantsbuild/pants/builds/547408642 for a sample run using this new Docker image.

@Eric-Arellano Eric-Arellano changed the title WIP: Add Centos 7 docker image to allow building Python 3.7 wheels WIP: Add Centos7 docker image to allow building Python 3.7 wheels Jun 18, 2019
@Eric-Arellano Eric-Arellano changed the title WIP: Add Centos7 docker image to allow building Python 3.7 wheels Add Centos7 docker image to allow building Python 3.7 wheels Jun 18, 2019
make \
devtoolset-7-gcc{,-c++} \
git \
java-1.8.0-openjdk-devel \
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should also be standardizing on at least java 11?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we support Java 11! Pants assumes tools.jar, which was removed in Java 9 per https://stackoverflow.com/a/53707739.

When running ./pants lint :: with brew installed Java 12, I get this exception: Exception message: Failed to locate tools.jar library.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump on this @benjyw - I imagine you've discovered this recently

@benjyw benjyw merged commit 7d86e23 into pantsbuild:master Jun 19, 2019
@Eric-Arellano Eric-Arellano deleted the centos7 branch June 19, 2019 16:02
Eric-Arellano added a commit that referenced this pull request Jun 20, 2019
Will close #7421.

We could not use Docker to build the Python 3.7 PEX because we only had a Centos6 image. Now that we have a Centos7 image thanks to #7892, we can use Docker for this shard, as verified by https://travis-ci.org/pantsbuild/pants/jobs/547836170.

This will unblock building Python 3.7 wheels, which will allow releasing a PEX that works with Python 3.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants