Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Centos7 docker image to allow building Python 3.7 wheels #7892

Merged
merged 7 commits into from Jun 19, 2019

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Jun 18, 2019

Per #7288, we will very soon want to replace usage of Centos6 for Centos7 to pay off tech debt. The other motivation for using Centos7 is that we could start to build Python 3.7 wheels for Linux, meaning that we could ship a Python 3.7 PEX.

This is pre-work for both goals by adding the base Centos7 image, which we will publish to DockerHub.

See https://travis-ci.org/pantsbuild/pants/builds/547408642 for a sample run using this new Docker image.

@Eric-Arellano Eric-Arellano changed the title WIP: Add Centos 7 docker image to allow building Python 3.7 wheels WIP: Add Centos7 docker image to allow building Python 3.7 wheels Jun 18, 2019

@Eric-Arellano Eric-Arellano force-pushed the Eric-Arellano:centos7 branch from 18c39b6 to 0d1765c Jun 18, 2019

@Eric-Arellano Eric-Arellano force-pushed the Eric-Arellano:centos7 branch from 0d1765c to 021d4e4 Jun 18, 2019

@Eric-Arellano Eric-Arellano changed the title WIP: Add Centos7 docker image to allow building Python 3.7 wheels Add Centos7 docker image to allow building Python 3.7 wheels Jun 18, 2019

@benjyw

benjyw approved these changes Jun 19, 2019

make \
devtoolset-7-gcc{,-c++} \
git \
java-1.8.0-openjdk-devel \

This comment has been minimized.

Copy link
@benjyw

benjyw Jun 19, 2019

Contributor

Probably we should also be standardizing on at least java 11?

This comment has been minimized.

Copy link
@Eric-Arellano

Eric-Arellano Jun 19, 2019

Author Contributor

I don't think we support Java 11! Pants assumes tools.jar, which was removed in Java 9 per https://stackoverflow.com/a/53707739.

When running ./pants lint :: with brew installed Java 12, I get this exception: Exception message: Failed to locate tools.jar library.

@benjyw benjyw merged commit 7d86e23 into pantsbuild:master Jun 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:centos7 branch Jun 19, 2019

Eric-Arellano added a commit that referenced this pull request Jun 20, 2019

Use Docker to build Python 3.7 PEX in CI (#7899)
Will close #7421.

We could not use Docker to build the Python 3.7 PEX because we only had a Centos6 image. Now that we have a Centos7 image thanks to #7892, we can use Docker for this shard, as verified by https://travis-ci.org/pantsbuild/pants/jobs/547836170.

This will unblock building Python 3.7 wheels, which will allow releasing a PEX that works with Python 3.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.