Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefactor: Extract store and sharded_lmdb into their own crates #7904

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

commented Jun 19, 2019

I'm about to introduce a second wrapper around ShardedLmdb separate from Store, and this will make it easier to introduce this.

This is just a set of extractions of types; there are no functional changes here.

@illicitonion illicitonion requested a review from stuhood Jun 19, 2019

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/local-process-execution-cache branch from 3a18f8b to 2cf146d Jun 19, 2019

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/local-process-execution-cache branch from 2cf146d to bfc7751 Jun 20, 2019

@blorente blorente self-requested a review Jun 20, 2019

@blorente
Copy link
Contributor

left a comment

LGTM, small questions rather than suggestions :)

Err(blocking_err) => Err(format!("Unable to run blocking task to load_bytes in local ByteStore on tokio runtime: {}", blocking_err)),
}
}).to_boxed()
let (env, db, _) = dbs.clone()?.get(&digest.0);

This comment has been minimized.

Copy link
@blorente

blorente Jun 20, 2019

Contributor

Is this formatting change intentional? I'm assuming it is, but it looks suspiciously like IntelliJ messing things up.

This comment has been minimized.

Copy link
@illicitonion

illicitonion Jun 20, 2019

Author Contributor

It is whatever rustfmt did for me. That said, unindenting it was fine by rustfmt too, so... Ugh, I miss formatters which have one true style :)

use std::sync::Arc;
use std::time;
use tempfile::TempDir;

use super::MAX_LOCAL_STORE_SIZE_BYTES;

This comment has been minimized.

Copy link
@blorente

blorente Jun 20, 2019

Contributor

I'm a little bit confused as to why this lives here, is this constant fs-dependent?

This comment has been minimized.

Copy link
@illicitonion

illicitonion Jun 20, 2019

Author Contributor

Moved some things around, added some comments

illicitonion added some commits Jun 20, 2019

Shrink the directories LMDB by a few orders of magnitude
Directories are tiny. Hopefully this will help us avoiding OOMing on CI.
fmt

@illicitonion illicitonion merged commit 6890cc0 into pantsbuild:master Jun 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/local-process-execution-cache branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.