Prefactor: Extract store and sharded_lmdb into their own crates #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
dwagnerhall/local-process-execution-cache
branch
from
3a18f8b
to
2cf146d
Compare
illicitonion
force-pushed
the
dwagnerhall/local-process-execution-cache
branch
from
2cf146d
to
bfc7751
Compare
blorente
approved these changes
Jun 20, 2019
src/rust/engine/fs/store/src/lib.rs
Outdated
| Err(blocking_err) => Err(format!("Unable to run blocking task to load_bytes in local ByteStore on tokio runtime: {}", blocking_err)), | ||
| } | ||
| }).to_boxed() | ||
| let (env, db, _) = dbs.clone()?.get(&digest.0); |
There was a problem hiding this comment.
Is this formatting change intentional? I'm assuming it is, but it looks suspiciously like IntelliJ messing things up.
There was a problem hiding this comment.
It is whatever rustfmt did for me. That said, unindenting it was fine by rustfmt too, so... Ugh, I miss formatters which have one true style :)
src/rust/engine/fs/store/src/lib.rs
Outdated
| use std::sync::Arc; | ||
| use std::time; | ||
| use tempfile::TempDir; | ||
|
|
||
| use super::MAX_LOCAL_STORE_SIZE_BYTES; |
There was a problem hiding this comment.
I'm a little bit confused as to why this lives here, is this constant fs-dependent?
There was a problem hiding this comment.
Moved some things around, added some comments
Directories are tiny. Hopefully this will help us avoiding OOMing on CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm about to introduce a second wrapper around
ShardedLmdbseparate fromStore, and this will make it easier to introduce this.This is just a set of extractions of types; there are no functional changes here.