Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move reading and writing bytes from Store to ShardedLmdb #7909

Merged
merged 1 commit into from Jun 21, 2019
Merged

Move reading and writing bytes from Store to ShardedLmdb #7909

merged 1 commit into from Jun 21, 2019

Conversation

illicitonion
Copy link
Contributor

I will want to use this functionality from my other ShardedLmdb consumer

@illicitonion illicitonion mentioned this pull request Jun 20, 2019
Merged
stuhood
stuhood approved these changes Jun 21, 2019
View reviewed changes
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please hold off on merging until after #7922 is in.

@illicitonion illicitonion merged commit b11904d into pantsbuild:master Jun 21, 2019
@illicitonion illicitonion deleted the dwagnerhall/local-process-execution-cache/store-writes branch June 21, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@blorente blorente Awaiting requested review from blorente

@Eric-Arellano Eric-Arellano Awaiting requested review from Eric-Arellano

@cattibrie cattibrie Awaiting requested review from cattibrie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@illicitonion @stuhood