Report zipkin spans regardless of goal version. #7915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Jun 20, 2019
cattibrie
suggested changes
Jun 21, 2019
tests/python/pants_test/reporting/test_reporting_integration.py
Outdated
Show resolved
Hide resolved
tests/python/pants_test/reporting/test_reporting_integration.py
Outdated
Show resolved
Hide resolved
added 2 commits
June 21, 2019 13:55
engine we use to run requested goals.
hrfuller
force-pushed
the
hfuller/fix-zipkin-metrics
branch
from
21d3dce
to
68419d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fixes #7386
Goals which use the v2 engine were not exporting zipkin spans because the code doing the exporting was inside the context of the legacy graph, which isn't used during v2 engine goal execution.
Solution
Moved the zipkin bulk export code to the local pants runner so that it gets called regardless of which engine is run.
Result
Users can now see spans / timings from engine workunits displayed through zipkin dash for both v1 and v2 goals.