Don't memoize description in process execute memoization

[gshuflin]

#7745, we should revisit this solution when #7907 is decided upon

[Eric-Arellano]

Looks great other than one place to deduplicate!

[Eric-Arellano]

In Rust, can you use a partial function to reduce the duplication? Like this:

const createProcessRequest = (description: str) => ExecuteProcessRequest([], BTree(), ..., description)

Easiest way to do this is probably an inner function like this https://stackoverflow.com/a/26685687.

Then your test can be:

fn execute_process_request_equality() {
  fn create_execute_process_request(description: str) {
    ...
  }

 let a = create_execute_process_request("One message");
 let b =  create_execute_process_request("Different message");
 
 assertions;
}

[illicitonion]

The rust-ish way of this would be something like:

  let make_epr = |description: &'static str| ExecuteProcessRequest {
      argv: vec![],
      env: BTreeMap::new(),
      input_files: hashing::EMPTY_DIGEST,
      output_files: BTreeSet::new(),
      output_directories: BTreeSet::new(),
      timeout: std::time::Duration::new(0, 0),
      description: description.to_owned(),
      jdk_home: None,
    };

let a = make_epr("One message");
let b = make_epr("Different message");

[illicitonion]

Thanks for picking this up!

[illicitonion]

Unfortunately this isn't quite how the Hash API works; what you're actually comparing here is that () == ().

I think you need to do something like:

fn hash<Hashable: Hash>(hashable: &Hashable) -> u64 (
  let mut hasher = DefaultHasher::new();
  hashable.hash(&mut hasher);
  hasher.finish()
}

and then compare:

hash(&a) and hash(&b)

[illicitonion]

Clippy is probably going to complain at you for using format!(&'static str) because it's significantly slower than any of:
"One message".to_string(), "One message".to_owned(), or String::from("One message")

In a test it doesn't matter so much, but it's probably a good habit to get into :)

[illicitonion]

The rust-ish way of this would be something like:

  let make_epr = |description: &'static str| ExecuteProcessRequest {
      argv: vec![],
      env: BTreeMap::new(),
      input_files: hashing::EMPTY_DIGEST,
      output_files: BTreeSet::new(),
      output_directories: BTreeSet::new(),
      timeout: std::time::Duration::new(0, 0),
      description: description.to_owned(),
      jdk_home: None,
    };

let a = make_epr("One message");
let b = make_epr("Different message");

[illicitonion]

It's probably worth also adding a test which shows that if something other than description changes, the requests are equal and do hash the same, as we're messing with that generality.