Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pex 1.6.8. #7962

Merged
merged 2 commits into from Jul 3, 2019

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

commented Jun 27, 2019

This picks up fixes to PEX_PYTHON and PEX_PYTHON_PATH handling and
allows us to simplify pex execution slightly.

@jsirois jsirois requested review from stuhood, Eric-Arellano and CMLivingston and removed request for stuhood Jun 27, 2019

"""
chosen_interpreter_binary_path = interpreter.binary
return {
'PEX_IGNORE_RCFILES': '1',
'PEX_PYTHON': chosen_interpreter_binary_path,

This comment has been minimized.

@jsirois jsirois force-pushed the jsirois:pex/upgrade branch from 11787ec to d0ac1ad Jun 27, 2019

@stuhood stuhood requested review from blorente and removed request for stuhood Jun 27, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Yay simplicity!

jsirois added some commits Jun 27, 2019

Upgrade to pex 1.6.8.
This picks up fixes to `PEX_PYTHON` and `PEX_PYTHON_PATH` handling and
allows us to simplify pex execution slightly.

@jsirois jsirois force-pushed the jsirois:pex/upgrade branch from d0ac1ad to a96f6b7 Jun 28, 2019

@blorente
Copy link
Contributor

left a comment

I have started an internal testing battery against this change, to see if we're missing any case with test coverage. Assuming that's well and good, lgtm.

@jsirois jsirois merged commit 8651b37 into pantsbuild:master Jul 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:pex/upgrade branch Jul 3, 2019

jsirois added a commit to jsirois/pants that referenced this pull request Jul 3, 2019

Fix ensure_interpreter_search_path_env docs.
This is a follow-up to pantsbuild#7962
[ci skip]  # Documentation-only change.

jsirois added a commit that referenced this pull request Jul 3, 2019

Fix ensure_interpreter_search_path_env docs. (#8000)
This is a follow-up to #7962
[ci skip]  # Documentation-only change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.