Upgrade to pex 1.6.8. #7962
Merged
Upgrade to pex 1.6.8. #7962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
requested review from
stuhood,
Eric-Arellano and
CMLivingston
and removed request for
stuhood
jsirois
commented
Jun 27, 2019
| """ | ||
| chosen_interpreter_binary_path = interpreter.binary | ||
| return { | ||
| 'PEX_IGNORE_RCFILES': '1', | ||
| 'PEX_PYTHON': chosen_interpreter_binary_path, |
There was a problem hiding this comment.
NB: The relevant logic is here: https://github.com/pantsbuild/pex/blob/f5e00ad07a4943b101b4d17f94a1146856cfb585/pex/pex_bootstrapper.py#L131-L173
This picks up fixes to `PEX_PYTHON` and `PEX_PYTHON_PATH` handling and allows us to simplify pex execution slightly.
blorente
approved these changes
Jun 28, 2019
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Jul 3, 2019
This is a follow-up to pantsbuild#7962 [ci skip] # Documentation-only change.
jsirois
added a commit
that referenced
this pull request
Jul 3, 2019
This is a follow-up to #7962 [ci skip] # Documentation-only change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up fixes to
PEX_PYTHONandPEX_PYTHON_PATHhandling andallows us to simplify pex execution slightly.