Remove text_type and binary_type wrappers #7970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
requested review from
illicitonion,
ity,
cosmicexplorer and
blorente
stuhood
reviewed
Jun 28, 2019
| @@ -537,7 +536,9 @@ def satisfied_by_type(self, obj_type): | |||
| return issubclass(obj_type, self._types) | |||
|
|
|||
|
|
|||
| _string_type_constraint = SubclassesOf(binary_type, text_type) | |||
| # TODO(#6071): We should in general not allow bytes _and_ str. The whole point of Py3 was to decide | |||
There was a problem hiding this comment.
It would be good to open a more specific ticket for this probably.
There was a problem hiding this comment.
I'm planning on addressing this pretty soon, which is why I didn't open a new ticket. Also, #6071 already has several checklist items to tighten up expectations around str vs. bytes.
Eric-Arellano
force-pushed
the
replace-text-type
branch
from
25dc22f
to
7364869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now safely use
strandbyteseverywhere.