No longer use string_types
#7980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
force-pushed
the
dont-use-string-types
branch
from
42dd2ac
to
5f78352
Compare
|
I can't reproduce the integration shard #4 failures either on macOS or Ubuntu VM :/ Going to try to get this working by analyzing the changes and pushing to CI. Pardon that this will result in some email spam. FYI example error: https://travis-ci.org/pantsbuild/pants/jobs/552230697#L1039. |
Eric-Arellano
force-pushed
the
dont-use-string-types
branch
2 times, most recently
from
4b7d3ab
to
5f78352
Compare
Eric-Arellano
changed the title
string_typesstring_types
|
So turns out I just needed to wipe the Travis cache.. ready for review now. |
Eric-Arellano
requested review from
cosmicexplorer,
stuhood,
jsirois,
benjyw and
blorente
benjyw
approved these changes
Jun 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
string_types, which is the same asTuple[bytes, str], is a vestige of Python 2's loose mixing of unicode and byte strings. Python 3 intentionally makes you choose which you want to use, which we should be doing too for more sane code.While this technically violates the deprecation policy for some APIs, this coincides with the even larger breaking change of no longer supporting Python 2. It is almost guaranteed that users who extend Pants will already need to make changes, so it is helpful to land this API change at the same time that people are modernizing their
pants-plugins.Further, several of the below instances do not make sense to support bytes—they would crash were someone to pass bytes and it is solely happenstance that no one has reported trying. We had only kept the support for bytes due to Python 2's frequent use of byte strings.