Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
No longer use `string_types` #7980
While this technically violates the deprecation policy for some APIs, this coincides with the even larger breaking change of no longer supporting Python 2. It is almost guaranteed that users who extend Pants will already need to make changes, so it is helpful to land this API change at the same time that people are modernizing their
Further, several of the below instances do not make sense to support bytes—they would crash were someone to pass bytes and it is solely happenstance that no one has reported trying. We had only kept the support for bytes due to Python 2's frequent use of byte strings.
I can't reproduce the integration shard #4 failures either on macOS or Ubuntu VM :/ Going to try to get this working by analyzing the changes and pushing to CI. Pardon that this will result in some email spam.
FYI example error: https://travis-ci.org/pantsbuild/pants/jobs/552230697#L1039.