Add __init__.py to directories created by grpcio #7984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Problem
When trying to create a dist tarball from `python_grpcio_library`
using `provides=setup_py`, the `find-namespace-packages` step fails
with the following errors:
$ ./pants setup-py ...
[...]
..._pb2.py is source but does not belong to a package.
..._pb2_grpc.py is source but does not belong to a package.
That happens because the `find_packages()` method in `setup_py.py`
ignores subdirectories that do not contain `__init__.py`.
### Solution
This commit adds an empty `__init__.py` file to each directory
created by grpcio.
### Result
A package with gRPC interfaces is properly created.
Eric-Arellano
requested changes
Jun 30, 2019
tests/python/pants_test/backend/codegen/grpcio/test_multiple_grpcio_gen.py
Outdated
Show resolved
Hide resolved
|
Also looks like the lint shard failed due to import order. One tip: run In this particular instance, you can fix the import error by running |
Eric-Arellano
requested changes
Jun 30, 2019
Per PR: pantsbuild#7984
Eric-Arellano
approved these changes
Jul 1, 2019
Per PR: pantsbuild#7984
stuhood
reviewed
Jul 2, 2019
Eric-Arellano
approved these changes
Jul 4, 2019
Eric-Arellano
approved these changes
Jul 4, 2019
|
Thank you, Eric! You too have a great 4th of July! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When trying to create a dist tarball from
python_grpcio_libraryusingprovides=setup_py, thefind-namespace-packagesstep fails with the following errors:That happens because the
find_packages()method insetup_py.pyignores subdirectories that do not contain__init__.py.Solution
This commit adds an empty
__init__.pyfile to each directory created by grpcio.Result
A package with gRPC interfaces is properly created.