Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove six library #7985

Merged
merged 3 commits into from Jul 1, 2019
Merged

Remove six library #7985

merged 3 commits into from Jul 1, 2019

Conversation

Eric-Arellano
Copy link
Contributor

However, contrib.python.checks.checker does still need six, which was setup in #7982 to be isolated from this change.

blorente
blorente approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@blorente blorente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Eric-Arellano Eric-Arellano merged commit 51aca06 into pantsbuild:master Jul 1, 2019
@Eric-Arellano Eric-Arellano deleted the remove-six branch July 1, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blorente blorente blorente approved these changes

@stuhood stuhood Awaiting requested review from stuhood

@benjyw benjyw Awaiting requested review from benjyw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Eric-Arellano @blorente