Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most Python 2 issues from #6071 #7989

Merged

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

commented Jul 1, 2019

#6071 was used to keep track of several changes we could only make after dropping Python 2. This PR makes all those changes, minus changing some APIs to return NotImplemented in their equality dunder methods.

@benjyw

benjyw approved these changes Jul 1, 2019

@stuhood

stuhood approved these changes Jul 2, 2019

@Eric-Arellano Eric-Arellano merged commit 6916d8c into pantsbuild:master Jul 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:remove-remaining-py2-todos branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.