Fix pdb conflict in run_tracker stats request #8025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using here conflicts with [pdb's command](https://docs.python.org/3/library/pdb.html#pdbcommand-return), frustrating attempts to debug requests in the run tracker. seemed like a sensible alternative.
benjyw
approved these changes
Jul 8, 2019
stuhood
approved these changes
Jul 9, 2019
illicitonion
pushed a commit
that referenced
this pull request
Jul 10, 2019
Memoizing the response as r when posting stats in the run tracker conflicts with pdb's r(eturn) command, frustrating attempts to debug requests in the run tracker - res seemed like a sensible alternative. Also updated uses of .format to f-strings, per the updated style guide and Slack discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memoizing the response as
rwhen posting stats in the run tracker conflicts with pdb'sr(eturn)command, frustrating attempts to debug requests in the run tracker -resseemed like a sensible alternative.馃摑 Also updated uses of
.formatto f-strings, per the updated style guide and Slack discussion.