[pantsd] Clear the global state of subsystems earlier, plus refactorings #8130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
pushed a commit
that referenced
this pull request
Aug 1, 2019
…ngs (#8130) **Problem** In DaemonPantsRunner, we were clearing the global options state after we had warmed the v1 graph and ran every v2 rule. This means that those runs were running with potentially old state. **Solution** Move the clearing of Subsystem and related global state to before we compute v2 rules. This state is re-initialized in LocalPantsRunner.parse_options(), right after clearing. Commits should be independently reviewable. The first commit are some refactorings unrelated to this change, the second one is the actual change. I deemed this a small enough change to bunch them together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In DaemonPantsRunner, we were clearing the global options state after we had warmed the v1 graph and ran every v2 rule. This means that those runs were running with potentially old state.
Solution
Move the clearing of
Subsystemand related global state to before we compute v2 rules.This state is re-initialized in
LocalPantsRunner.parse_options(), right after clearing.Commits should be independently reviewable. The first commit are some refactorings unrelated to this change, the second one is the actual change. I deemed this a small enough change to bunch them together.