Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the workdir to be automatically managed as a symlink #8195

Merged
merged 25 commits into from Aug 22, 2019

Conversation

@patliu85
Copy link
Contributor

commented Aug 21, 2019

As a continuation of #8071

Problem

When running pants on a virtual filesystem, any directory that is not under source control is implemented as a symbolic link to a directory on a physical ("real filesystem") volume. This would break pants because it currently requires .pants.d directory (which is not under source control) to be a "real filesystem".

Solution

Add a new feature that would create .pants.d directory as a symlink to a physical volume when pants runs and after pants clean-all.

Fix any pants's goals that fail due to .pants.d's changes.

Result

This new feature can be enabled by setting --pants-physical-workdir-base=<dir_outside_buildroot>/workdirs.

stuhood and others added 24 commits Jul 16, 2019
WIP: Temporarily disable our import-time call to `reset_log_location`…
…, which guesses where to begin writing logs.
@stuhood
Copy link
Member

left a comment

Thanks!

@stuhood stuhood added this to the 1.19.x milestone Aug 21, 2019

@stuhood stuhood merged commit a24307e into pantsbuild:master Aug 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:pliu/pants.d-as-symlink branch Aug 22, 2019

stuhood added a commit that referenced this pull request Aug 22, 2019
Allow the workdir to be automatically managed as a symlink (#8195)
* Add the `--pants-physical-workdir-base` option.

* Inherently ignore the workdir and distdir.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.