Allow the workdir to be automatically managed as a symlink #8195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, which guesses where to begin writing logs.
stuhood
pushed a commit
that referenced
this pull request
Aug 22, 2019
* Add the `--pants-physical-workdir-base` option. * Inherently ignore the workdir and distdir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation of #8071
Problem
When running
pantson a virtual filesystem, any directory that is not under source control is implemented as a symbolic link to a directory on a physical ("real filesystem") volume. This would break pants because it currently requires.pants.ddirectory (which is not under source control) to be a "real filesystem".Solution
Add a new feature that would create
.pants.ddirectory as a symlink to a physical volume whenpantsruns and afterpants clean-all.Fix any
pants's goals that fail due to.pants.d's changes.Result
This new feature can be enabled by setting
--pants-physical-workdir-base=<dir_outside_buildroot>/workdirs.