Use NGContext.exit() instead of sys.exit(). #8239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ---- Previously, a compile error would cause the zinc wrapper to call `sys.exit(1)`, which killed the hot nailgun JVM process. Solution ---- This commit replaces `sys.exit(1)` with a call to `NGContext.exit(1)`, which is a Nailgun API to mimic `sys.exit(1)`, allowing the existing JVM process to continue running. Result ---- Users should experience a faster compile/debug workflows while iterating on code due to fewer JVM startups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, a compile error would cause the zinc wrapper to call
sys.exit(1), which killed the hot nailgun JVM process.Solution
This commit replaces
sys.exit(1)with a call toNGContext.exit(1), which is a Nailgun API to mimicsys.exit(1), allowing the existing JVM process to continue running.Result
Users should experience a faster compile/debug workflows while iterating on code due to fewer JVM startups.