Port more integration tests to V1 chroot and some to V2 #8365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
force-pushed
the
port-more-tests
branch
from
8f0c911
to
804a6e6
Compare
Eric-Arellano
changed the title
We just don't remote because it times out so much
Some progress is better than no progress!
Eric-Arellano
force-pushed
the
port-more-tests
branch
from
804a6e6
to
e839a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings ITs to:
Notably, this moves over several tests that were previously marked V1 no chroot but really could have been V1 chroot. While this does not actually remote any more tests, it helps to keep track of what work remains; it is much easier to port a V1 chroot test to V2 than a no-chroot target. This also prevents any regressions.