Run FUSE tests on OSX again #8453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
dwagnerhall/osxfuse
branch
2 times, most recently
from
3b72a5e
to
c0e3cba
Compare
illicitonion
changed the title
illicitonion
force-pushed
the
dwagnerhall/osxfuse
branch
from
c0e3cba
to
63eacbd
Compare
Eric-Arellano
approved these changes
Oct 11, 2019
benjyw
approved these changes
Oct 11, 2019
| # "casks": ["osxfuse"] | ||
| # } | ||
| # }, | ||
| # We need to use xcode8.3 because newer versions of OSX won't let new kexts be installed |
There was a problem hiding this comment.
Thanks for the clear and important comment!
| "before_install": [ | ||
| './build-support/bin/install_python_for_ci.sh "${PYENV_PY36_VERSION}"', | ||
| "brew cask install osxfuse", |
There was a problem hiding this comment.
It's important to have an equally lucid comment explaining why we do this and not use the standard travis "addons" thing.
|
The excellent "things you learned on this journey" should probably all be comments in the code... |
benjyw
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things I learnt on this journey:
addons) will either silently fail on older images because it's a really old brew, or will force an upgrade of brew which is super slow. Manually runningbrew cask installdoes not.opensslis already installed on the image, so we don't need to install it.brew install opensslit will spend minutes upgradingbrew, only to tell you thatopensslwas already installed.brew installwill succeed, things will just fail in weird ways.