Fix sorting of junit tests in presence of a timeout #8600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Nov 8, 2019
| target_to_failed_test = parse_failed_targets(test_registry, output_dir, parse_error_handler) | ||
|
|
||
| def sort_owning_target(t): | ||
| return t.address.spec if t else None | ||
| return t.address.spec if t else '' |
There was a problem hiding this comment.
Even with the NB above, I'd still add
NB: we use the empty string rather than None to ensure comparisons do not fail.
There was a problem hiding this comment.
There are now two comments in this method body, heh. I added one before seeing the one below.
There was a problem hiding this comment.
Feel free to update the below comment to simply say Python does not allow instead of Python 3 :) 40 more days until Python 2 is officially EOL!
stuhood
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we timeout or when junit XML is corrupted for some reason, it can prevent us from identifying the target that failed, which causes us to default to a
Nonecluster of tests.We knew this already though, and the codepath that parsed tests accounted for it. But we had missed a case.
Solution
Default to the empty string rather than
Nonewhen sorting tests.