Move ivy and coursier bootstrapping to BinaryUtil. #8637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
wisechengyi
approved these changes
Nov 17, 2019
| urls = [self.get_options().bootstrap_jar_url] | ||
| else: | ||
| urls = list(self.get_options().bootstrap_jar_urls) | ||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
stuhood
force-pushed
the
stuhood/ivy-and-coursier-on-binaryutil
branch
from
9883541
to
1e4bd45
Compare
benjyw
approved these changes
Nov 17, 2019
| except ivy.Error as e: | ||
| safe_delete(classpath) | ||
| raise self.Error('Failed to bootstrap an ivy classpath! {}'.format(e)) | ||
| with safe_concurrent_creation(classpath) as safe_classpath: |
There was a problem hiding this comment.
Do we actually need ivy to bootstrap itself? Why not directly fetch the version we want to use?
There was a problem hiding this comment.
I guess because of plugins?
pants/src/python/pants/ivy/bootstrapper.py
Lines 31 to 34 in c12fcbb
| else: | ||
| workunit.set_outcome(WorkUnit.SUCCESS) | ||
| def __init__(self, template_urls): | ||
| super(CoursierUrlGenerator, self).__init__() |
There was a problem hiding this comment.
This can be super().__init__().
| class IvyUrlGenerator(BinaryToolUrlGenerator): | ||
|
|
||
| def __init__(self, template_urls): | ||
| super(IvyUrlGenerator, self).__init__() |
There was a problem hiding this comment.
Ditto on Py3 style super(). I will add both these changes to the type checking PR I have up.
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Nov 17, 2019
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ivyandcoursierboth use an older pattern to bootstrap their initial jar (ivy continues on to actually resolve itself), meaning that they don't support multiple bootstrap URLs.Solution
Swap them to
BinaryTool/BinaryUtil, with a slight twist to allow them to use multiple bootstrap URLs in addition to accessing our S3 bucket.Result
Better defaults and less flaky bootstrapping of those tools.