Refactor V2 Black implementation #8671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on_target This will allow us to add rules/isort.py
Eric-Arellano
requested review from
illicitonion,
TansyArron and
pierrechevalier83
Eric-Arellano
changed the title
Eric-Arellano
force-pushed
the
refactor-black
branch
from
8b82563
to
172c173
Compare
stuhood
approved these changes
Nov 21, 2019
Eric-Arellano
commented
Nov 21, 2019
There was a problem hiding this comment.
So, there is potentially a larger concern with installing multiple auto-formatters this way. Which is that we haven't designed how to have multiple formatters depend on one another's output without knowing about eachother.
Oh! Interesting point! I don't think that should block this PR, but I agree that we'll need to design this interaction.
pierrechevalier83
approved these changes
Nov 21, 2019
illicitonion
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Looks good (subject to @pierrechevalier83 concerns, which hopefully we can resolve one way or another by adding a test :)) Thanks!
…gets (which is used by several partially_checkd targets)
TansyArron
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will soon be adding a V2 implementation for isort. This PR is prework to make the Black code a bit more generic so that we can have Black and isort coincide as two rules for
fmt-v2andlint-v2.python_fmtintorules/black.pyandtargets/formattable_python_targetrules/isort.pyand reuse theFormattablePythonTargetabstraction created originally for Black_generate_black_pex_args()and_generate_black_request()onto methods defined onBlackInput/BlackSetupto mirror ourPexdataclassBlackInputtoBlackSetupand add docstring explaining why we use this abstraction.async awaitstyle for rules--black-configto not usefingerprint=True, which is irrelevant in a V2 world.