Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version changes should invalidate pytest runs. #8790

Merged
merged 1 commit into from Dec 11, 2019

Conversation

OniOni
Copy link
Contributor

@OniOni OniOni commented Dec 10, 2019

Problem

When changing the pytest version or when adding/removing pytest plugins, pants does not invalidate targets.

Solution

Make sure pytest fingerprinting takes requirements into account.

Result

Test cache is correctly invalidated if we change any of the underlying requirements for pytest.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Eric-Arellano Eric-Arellano merged commit 2abfa90 into pantsbuild:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants