Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate --owner-of in favor of file arguments #9050

Merged
merged 4 commits into from Feb 3, 2020

Conversation

Eric-Arellano
Copy link
Contributor

File arguments are a better --owner-of, so there is no longer a reason to keep --owner-of.

Copy link
Contributor Author

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked by #9048, but otherwise ready for review :)

Copy link
Contributor

@blorente blorente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

src/python/pants/option/global_options.py Outdated Show resolved Hide resolved
Copy link
Contributor

@codealchemy codealchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

# Delete this line to force a full CI run for documentation-only changes.
[ci skip]  # Documentation-only change.
@Eric-Arellano Eric-Arellano merged commit 1ebe376 into pantsbuild:master Feb 3, 2020
@Eric-Arellano Eric-Arellano deleted the deprecate-owner-of branch February 3, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants