Remove --test-fast to always have better test caching
#9241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
approved these changes
Mar 5, 2020
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 6, 2020
…sbuild#9241)" This reverts commit 1cca3e3.
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Apr 17, 2020
) This gives users better caching by default (per-target caching) and prepares them for V2. In a followup, we likely want to deprecate the `--chroot` option to always chroot. Then, there will be theoretically no blockers for users upgrading to the V2 test runner. [ci skip-rust-tests] [ci skip-jvm-tests]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives users better caching by default (per-target caching) and prepares them for V2.
In a followup, we likely want to deprecate the
--chrootoption to always chroot. Then, there will be theoretically no blockers for users upgrading to the V2 test runner.