Rename ChrootedPythonSources to ImportablePythonSources and add Target API support
#9479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better expresses the intent. This doesn't really have to do with a chroot. Really, what we're doing is preparing the sources to be able to be imported by things like Pytest. # Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # No Rust changes made. # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests] # No JVM changes made.
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # No Rust changes made. # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests] # No JVM changes made.
Eric-Arellano
commented
Apr 6, 2020
| legacy_prepare_python_sources, | ||
| *determine_source_files.rules(), | ||
| *inject_init_rules(), | ||
| RootRule(Targets), |
There was a problem hiding this comment.
I had to do this to remove an error that rule was not reachable.
Strangely, this only happens when the await Get[SourceFiles](AllSourceFilesRequest) is there..I don't know why because AllSourceFilesRequest is already a RootRule and it's unclear to me how this Get would impact Targets not being reachable?
gshuflin
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrootedwas a misnomer. This rule didn't have much to do with a chroot. Rather, the rule is really preparing Python sources so that they may be imported and be run by something like Pytest.