Fix python 3.8 runtime type error #9502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the
create
method ofcore/test.py
there is a call toissubclass
with a value that can in principle be atyping.Union
. In Python 3.6 this works fine; however Python 3.8 changed the type oftyping.Union
in such a way as cause theissubclass
call to throw an exception at runtime.Solution
Add a check to ensure that the value being checked by
issubclass
is an instance oftype
to avoid this error.