Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TargetAdaptorWithOrigin #9544

Conversation

Eric-Arellano
Copy link
Contributor

Superseded by TargetWithOrigin. We will soon be able to also remove HydratedTargetWithOrigin.

[ci skip-rust-tests]
[ci skip-jvm-tests]

# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@Eric-Arellano
Copy link
Contributor Author

Hooray!

Indeed :D I'll be very excited when we can remove TargetAdaptor too. I think we'll be able to at least remove most of the subclasses like PythonBinaryAdaptor soon, even if we need to keep TargetAdaptor around until we require all plugin authors to have bindings.

@Eric-Arellano Eric-Arellano merged commit c8dfa54 into pantsbuild:master Apr 15, 2020
@Eric-Arellano Eric-Arellano deleted the remove-target-adaptor-with-origin branch April 15, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants