Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade Rust to 1.43.1 #9681

Merged
merged 9 commits into from
May 28, 2020
Merged

upgrade Rust to 1.43.1 #9681

merged 9 commits into from
May 28, 2020

Commits on May 28, 2020

  1. upgrade Rust to 1.43.0 

    # Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @stuhood
    Tom Dyas authored and stuhood committed May 28, 2020
    Configuration menu
    Copy the full SHA
    10661d9 View commit details
    Browse the repository at this point in the history

  2. fix clippy: single_component_path_imports 

    [ci skip-jvm-tests]
    @stuhood
    Tom Dyas authored and stuhood committed May 28, 2020
    Configuration menu
    Copy the full SHA
    803a54b View commit details
    Browse the repository at this point in the history

  3. clippy triggered on a "bug" in derivative crate 

    fixed by upgrading derivative to latest

Clippy output:

    Checking process_execution v0.0.1 (/Users/tdyas/TC/pants/src/rust/engine/process_execution)
error: this match could be written as a `let` statement
  --> process_execution/src/remote.rs:37:1
   |
37 | #[derivative(Debug)]
   | ^^^^^^^^^^^^^^^^^^^^
   |
note: the lint level is defined here
  --> process_execution/src/lib.rs:7:3
   |
7  |   clippy::all,
   |   ^^^^^^^^^^^
   = note: `#[deny(clippy::match_single_binding)]` implied by `#[deny(clippy::all)]`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
help: consider using `let` statement
   |
37 | let Derivative = #[derivative(Debug)];
38 | Derivative

See mcarton/rust-derivative#58. Fix was released in vw2.1.1.
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @stuhood
    Tom Dyas authored and stuhood committed May 28, 2020
    Configuration menu
    Copy the full SHA
    3c2cb8b View commit details
    Browse the repository at this point in the history

  4. fix up more single_component_path_imports clippy lints 

    [ci skip-jvm-tests]
    @stuhood
    Tom Dyas authored and stuhood committed May 28, 2020
    Configuration menu
    Copy the full SHA
    a233feb View commit details
    Browse the repository at this point in the history

  5. fix more single_component_path_imports 

    # Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @stuhood
    Tom Dyas authored and stuhood committed May 28, 2020
    Configuration menu
    Copy the full SHA
    f03dd62 View commit details
    Browse the repository at this point in the history

  6. more clippy lints 

    # Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @stuhood
    Tom Dyas authored and stuhood committed May 28, 2020
    Configuration menu
    Copy the full SHA
    f2553bf View commit details
    Browse the repository at this point in the history

  7. to 1.43.1 

    # Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @stuhood
    Tom Dyas authored and stuhood committed May 28, 2020
    Configuration menu
    Copy the full SHA
    5ecf1e5 View commit details
    Browse the repository at this point in the history

  8. another clippy lint 

    # Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @stuhood
    Tom Dyas authored and stuhood committed May 28, 2020
    Configuration menu
    Copy the full SHA
    f2cf4f8 View commit details
    Browse the repository at this point in the history

  9. Adjust our pins of grpc-rs and grpc to avoid a buggy submodule: see r… 

    …ust-lang/cargo#8258.

# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @stuhood
    stuhood committed May 28, 2020
    Configuration menu
    Copy the full SHA
    561beab View commit details
    Browse the repository at this point in the history