Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V2 dependees goal #9692

Merged
merged 2 commits into from May 5, 2020
Merged

Conversation

Eric-Arellano
Copy link
Contributor

Once we require plugin authors to have Target API bindings, this can replace the V1 goal.

This results in a substantial speedup because we no longer need to hydrate the sources for all targets.

benchmark

(This is running ./pants dependees :: 5 times before and 5 times after. See https://docs.google.com/spreadsheets/d/1_7wC0qYCrEYqVb0LKHfV8QreApoMRn2EpzF8ytneU-8/edit#gid=1814257311)

[ci skip-rust-tests]
[ci skip-jvm-tests]

# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
@Eric-Arellano Eric-Arellano requested a review from stuhood May 4, 2020 19:57
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/python/pants/backend/project_info/rules/dependees.py Outdated Show resolved Hide resolved
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
@Eric-Arellano Eric-Arellano merged commit 3ba7dcf into pantsbuild:master May 5, 2020
@Eric-Arellano Eric-Arellano deleted the dependees branch May 5, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants