Compute source roots in a rule. #9888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we computed the source root for a path outside the engine, via a utillity method. However we want to support marking source roots using a sentinel file, and this requires filesystem access in the computation, meaning that has to be done in a rule. This change introduces a set of rules for finding the source root for a path, and converts all v2 code to use those rules. [ci skip-rust-tests] [ci skip-jvm-tests]
benjyw
force-pushed
the
source_roots_rules
branch
from
cc3e0db
to
c2ce30c
Compare
benjyw
changed the title
|
Reviewers: This isn't just boilerplate, please double-check my logic. Thanks! |
[ci skip-rust-tests] [ci skip-jvm-tests]
[ci skip-rust-tests] [ci skip-jvm-tests]
stuhood
reviewed
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we computed the source root for a path outside the engine, via a utility method.
However we want to support marking source roots using a sentinel file, and this requires source root computation to have filesystem access, meaning it has to be done in a rule.
This change introduces a set of rules for finding the source root for a path, and converts all v2 code to use those rules.
Note that this change introduces a new field,
root_to_relfiles, onSourceRootStrippedSources, which maps from each found source root to the list of files under that source root. This allows us to re-use source root stripping logic in places where we previously replicated it. V2 Engine FTW!A future change will leverage this change to support sentinel files.
[ci skip-rust-tests]
[ci skip-jvm-tests]