Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEX wheel support fetches the wrong wheel variant (cp27m instead of cp27mu) #398

Closed
apollo13 opened this issue Aug 4, 2017 · 3 comments
Closed

Comments

@apollo13
Copy link

apollo13 commented Aug 4, 2017

When specifying the platform there does not seem to be a way to specify the abi tag. This results in

 msgpack_python-0.4.7-cp27-cp27m-manylinux1_x86_64.whl

getting pulled in instead of

 msgpack_python-0.4.7-cp27-cp27mu-manylinux1_x86_64.whl

which uses UCS4 instead of UCS2 and is basically what every linux distribution uses (according to https://github.com/pypa/manylinux)

@apollo13 apollo13 changed the title PEX wheel support fetches the wrong wheel variant cp27m instead of cp27mu PEX wheel support fetches the wrong wheel variant (cp27m instead of cp27mu) Aug 4, 2017
@kwlzn
Copy link
Contributor

kwlzn commented Aug 9, 2017

this is a known issue for folks resolving directly against pypi, but it'd be good to provide a repro here to confirm this is fixed in the upcoming work.

@apollo13
Copy link
Author

apollo13 commented Aug 9, 2017

This can be used to repro:

pex msgpack-python==0.4.7 -o test.zip --platform=manylinux1_x86_64 --no-build --wheel
unzip -l test.zip|grep cp27mu

@kwlzn
Copy link
Contributor

kwlzn commented May 16, 2018

@apollo13 platform/impl/abi tags are now directly targetable as of pex 1.4.0:

[omerta ~]$ pex msgpack-python==0.4.7 -o /tmp/throwaway --platform=linux-x86_64-cp-27-mu --no-build
[omerta ~]$ unzip -l /tmp/throwaway | grep cp27mu | head -1
warning [/tmp/throwaway]:  25 extra bytes at beginning or within zipfile
  (attempting to process anyway)
     1385  05-15-2018 17:33   .deps/msgpack_python-0.4.7-cp27-cp27mu-manylinux1_x86_64.whl/msgpack/__init__.py

(also noting that manylinux support is intended to be implicit, so you needn't specify it exactly on the commandline - any linux platform will implicitly pickup manylinux wheels now)

@kwlzn kwlzn closed this as completed May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants