Silence stdout/stderr during Pants setup. #375
Conversation
There was a problem hiding this comment.
Thanks for splitting this up. In addition to the details of the file:
- how does a user know how to find this file, if they need to? Are there docs we could augment with a sentence? (There's the additional issue of the venv path being non-obvious with hashes in it, but that may be impossible to solve?)
- is this something we can add a test for do it doesn't regress?
I'm sure we could.. do you think it's worth looking into? I assume it's the part about not leaking output to stdout during bootstrapping.. checking the presence of the In that case, it feels like we might prefer looking into adding support for something to query the lift runtime for the various resulting paths etc. perhaps something like |
Yeah, just keeping |
I had a long reply that started out in favour of not testing this, but which in the end concluded that a test is worthwhile, as we want to ensure stdout is clean, regardless of what is being done during bootstrap, so it would protect not only against this fix in particular, but against all future changes that introduces new stuff during bootstrapping as well. I'll look into it :) |
| @@ -238,7 +248,7 @@ fn test_pants_bin_name_handling(scie_pants_scie: &Path) { | |||
| false, | |||
| r#" | |||
| [GLOBAL] | |||
| pants_version = "2.15.0rc5" | |||
| pants_version = "2.18.0" | |||
There was a problem hiding this comment.
By using the same pants version consistently, we avoid having to download and bootstrap more versions than necessary.
|
@huonw OK, I've added a test verifying bootstrap doesn't pollute stdout. PTAL :) |
pantsbuild/pants#20315 is now fixed (in pantsbuild/scie-pants#375 / https://github.com/pantsbuild/scie-pants/releases/tag/v0.10.8), so the sync_docs workflow can be slightly slicker.
~Look at the Python tag in the Pants PEX filename~ Cycle through all supported Python versions and check the PEX download URL using HEAD for each one to infer the Python version to use when installing Pants, when using a version of Pants that we don't already know which version of Python to use. ~Drop support for `PANTS_SHA`.~ Done in #376. ~Silence the install step, capturing the output to a `pants-install.log` file in the science cache.~ Done in #375. --------- Co-authored-by: Huon Wilson <wilson.huon@gmail.com>
Closes pantsbuild/pants#20315
Broken out from #351