Drop support for PANTS_SHA
#376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This includes the changes from #375 which should land first. (i.e. only the last commit needs to be reviewed for this PR.) |
kaos
force-pushed
the
kaos/drop-PANTS_SHA-support
branch
from
8215abc
to
1bd66c3
Compare
huonw
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Nice.
Just confirming my thought process for validating the removal of functionality that users might be using:
- we stopped uploading wheels for every
maincommit in Do not publish wheels for all SHAs, and publish to PyPI from Github Actions. pants#19028, I believe, was first released in 2.17.0a0; that is, we haven't been publishing wheels for commits for some of the 2.17.x release cycle, and all of 2.18.x onwards - if someone is still using a specific commit from before 2.17.0a0 or earlier... then they'd presumably be happy enough pinning to a particular
scie-pantsversion too (e.g. 0.10.8)
kaos
added a commit
that referenced
this pull request
May 22, 2024
~Look at the Python tag in the Pants PEX filename~ Cycle through all supported Python versions and check the PEX download URL using HEAD for each one to infer the Python version to use when installing Pants, when using a version of Pants that we don't already know which version of Python to use. ~Drop support for `PANTS_SHA`.~ Done in #376. ~Silence the install step, capturing the output to a `pants-install.log` file in the science cache.~ Done in #375. --------- Co-authored-by: Huon Wilson <wilson.huon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PANTS_SHAfeature was deprecated with the release0.10.0ofscie-pants.Broken out of #351