Fix error when casting blank literal score as int for ongoing game #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the error in which I could not call
box_score()
during the top of an inning for an ongoing game.box_score()
would result in throwing an error because__init__
did not account for the score string for the top of an inning being a blank literal i.e.''
and would attempt to cast''
as anint
. I also got rid of thetry
andexcept
because it felt hacky and instead I check to see whether the score string returnstrue
whenisdigit()
is called before deciding whether or not to cast the score string as anint
.Related issue that I opened: #127