Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error from previous PR that changed casting scores #130

Merged
merged 1 commit into from May 17, 2019
Merged

Fix error from previous PR that changed casting scores #130

merged 1 commit into from May 17, 2019

Conversation

AndrewYinLi
Copy link
Contributor

This PR is intended to fix an error my previous PR created. I didn't account for home_score and away_score being an int already because the code from before #128 casted the two variables as int. When isdigit() is called on an int, an error is thrown, so I added changes to check whether home_score and away_score are str objects before calling isdigit().

@AndrewYinLi
Copy link
Contributor Author

AndrewYinLi commented May 16, 2019

Also the codeclimate issues are trivial and aren't worth making a new function for.

@panzarino panzarino merged commit 18b3aee into panzarino:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants