-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for new EWBF #130
Changes for new EWBF #130
Conversation
1bash.template
Outdated
@@ -451,7 +453,9 @@ CLAYMORE_OPTS="" # Claymore optional arguments. | |||
EQUIHASH_MINER="DSTM" # Choose "DSTM" or "EWBF" or "BMINER" | |||
EQUIHASH_WALLET_FORMAT="$WALLET_ADDRESS_FORMAT" # Chose the format your pool requires | |||
DSTM_OPTS="" # DSTM Miner optional arguments add "--telemetry=$IPW:42000" if you want web info | |||
EWBF_VERSION="3_4" # choose 3_3 or 3_4 # EWBF ZEC Miner version | |||
EWBF_VERSION="3_4" # choose 3_3 or 3_4 or new v0_3# EWBF ZEC Miner version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would be better to explain that the version should match the name of the miner folder. And maybe it is better to distinguish EWBF3 and EWBF0 since in case someone would like to use EWBF3 for Zcash and EWBF0 for Bitcoin Gold the current solution doesn't allow such an option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ewbf version naming is so confusing
Older versions are 0.3.3b and 0.3.4b, and ...,New one is v0.3
The new version should be capable of mining older algorithms.
With EWBF0 and EWBF3 where do we assign which coin to be mine with which miner?
We only have equihash_miner variable, then we need a EWBF0 coins and EWBF3 coins and so many new variables in 0miner...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly the new version has no support for the old algo… shame on ewbf for choosing the most horrible naming and verioning scheme...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol ... No idea whats with all the 0.3 versioning schemes.
Problem only occur if user wants to auto switch multiple new and old equihash algos with wtm.
Lets hope dstm gives a general update for both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so just change that comment removing any explict reference to ZEC, and add a whitespace between 'v0.3' and '#', just in case, I don't want to see someone using 'v0.3#' as the version 😅
then | ||
HCD="${NVOC}/miners/ewbf/$EWBF_VERSION/miner --eexit 3 --fee $EWBF_PERCENT --pec --server ${!xpool} --user ${!xaddr}${!xwallet}${!xwork} --pass $MINER_PWD --port ${!xport} $EWBF_OPTS ${!xext}" | ||
else | ||
HCD="${NVOC}/miners/ewbf/$EWBF_VERSION/miner --fee $EWBF_PERCENT --server ${!xpool} --user ${!xaddr}${!xwallet}${!xwork} --pass $MINER_PWD --port ${!xport} $EWBF_OPTS ${!xext}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be a problem here, The coint->algo binding in 1bash associates BTG to "EQUIHASH", but WTM is calling the new algo "EquihashBTG" https://whattomine.com/coins/214-btg-equihash
Should we consider each equihash variant as a different algo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we separate algos, the problem with switching different variants is addressed also, we would have:
old equihash->old ewbf (like it is in current tree)
equihashbtg, and other variants -> new ewbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually WTM totally removed BTG from its coin calculation page, may add a new equihash algo for it... or not.
So lets wait and see how it goes.
Since users are starting to ask for new EWBF, I say we go forward with it as is, later we make changes if new algo names introduced by wtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I hope nobody will try switching over equihash variants meanwhile.
They can't switch to new equihash algos like BTG via wtm_switcher as they are removed from coins page. |
Yeah, with "meanwhile" I meant from now to whenever it is listed again. |
MPH switching should work instead. |
We will make a fix for wtm "when" they showed up. |
How does mph switcher handle new algos? |
I see mph removed BTG from equihash algo mining port 17023 too |
It uses different algo identifiers (those one written lowercase in OC settings) so we only need to add another coin to the mph_config.json and it works. |
Yes, there is only the single coin port at 20595, but since it is the only coin using that algo makes no difference. You can see it as an algo port with only one coin. |
Here is the question I posted on this topic in wtm thread: |
Changes for new EWBF