Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] fix message parsing in python ivy #127

Merged
merged 1 commit into from
Sep 24, 2020
Merged

[fix] fix message parsing in python ivy #127

merged 1 commit into from
Sep 24, 2020

Conversation

gautierhattenberger
Copy link
Member

to handle a mix of standard and request messages

this is a side effect of #122

noether
noether approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@noether noether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that with this fix, I do not see anymore the error 4 parameters given, 3 expected when I am processing the messages in the python gvfApp .

Thanks!

@gautierhattenberger gautierhattenberger merged commit fadadb3 into master Sep 24, 2020
@gautierhattenberger gautierhattenberger deleted the fix-ivy_message_parsing branch September 24, 2020 15:37
This was referenced Sep 24, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noether noether noether approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gautierhattenberger @noether