feat(message-document): Add origami loading indicator #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
marhkb
force-pushed
the
marhkb/feat/message-document/loading-indicator
branch
from
2f73c2e
to
d5a2565
Compare
|
Currently the mask isn't applies to the loading indicator
I think the loading indicator can be put inside StatusIndicator Then it'l' be masked and work nicely with things like #566 |
marhkb
force-pushed
the
marhkb/feat/message-document/loading-indicator
branch
from
d5a2565
to
00e4fbc
Compare
yuraiz
suggested changes
Oct 1, 2023
Co-authored-by: yuraiz <yuraiz@users.noreply.github.com>
marhkb
force-pushed
the
marhkb/feat/message-document/loading-indicator
branch
from
00e4fbc
to
a7756b6
Compare
yuraiz
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from #496