Make touch honour if: and unless: options #1349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The on_touch callback was not honouring the if: or unless: options that were set in the model config.
These tests were actually testing the opposite of what they said they were testing.
|
I don't know this area well but this looks good to me, what do you think @jaredbeck? I think we'll want to squash the commits. |
jaredbeck
added a commit
that referenced
this pull request
Nov 28, 2021
* Honour if: and unless: options in on_touch The on_touch callback was not honouring the if: or unless: options that were set in the model config. * Fix some test descriptions These tests were actually testing the opposite of what they said they were testing. * Doc: changelog entry for #1349 [ci skip] Co-authored-by: Nigel Williams <nigel.williams@marketplacer.com>
|
Thanks Nigel, nice job on the tests. Merged as #1354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
Check the following boxes:
master(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.