Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in paper_trails callbacks docs #878

Conversation

MistaTwista
Copy link

@MistaTwista MistaTwista commented Oct 17, 2016

There was a typo in callback names not paper_trail.on_destroy, but paper_trail_on_destroy, etc.

There was a typo in callbacks names not .on_destroy, but _on_destroy, etc.
@batter
Copy link
Collaborator

batter commented Oct 17, 2016

This is actually the desired syntax for the PaperTrail 5.2+ if I'm not mistaken, right @jaredbeck?

Using either syntax should work, but in the future I believe we want to deprecate the paper_trail_method_name syntax in favor of the paper_trail.method_name syntax.

@MistaTwista - See #719 for more context.

@jaredbeck
Copy link
Member

Thanks, Maxim, but paper_trail.on_create (with dot) is correct. See #719

@jaredbeck jaredbeck closed this Oct 17, 2016
@jaredbeck
Copy link
Member

Using either syntax should work, but in the future I believe we want to deprecate the paper_trail_method_name syntax in favor of the paper_trail.method_name syntax.

Those methods have already been removed, by #864

@batter
Copy link
Collaborator

batter commented Oct 17, 2016

@jaredbeck - I meant in released versions of PaperTrail (aka v5.x)

@jaredbeck
Copy link
Member

@jaredbeck - I meant in released versions of PaperTrail (aka v5.x)

Ah, quite right. They've been removed, but only in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants