Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated model methods #864

Merged
merged 2 commits into from
Sep 9, 2016
Merged

Conversation

jaredbeck
Copy link
Member

@jaredbeck jaredbeck commented Sep 8, 2016

Removes the model methods deprecated in 5.2.0 (by #719) Use paper_trail.x instead of x.

This business with changing Fluxor on the fly is pretty confusing.
It would probably be better to have different models, rather than
changing Fluxor's PT config on the fly.
@jaredbeck jaredbeck merged commit c37e489 into master Sep 9, 2016
@jaredbeck jaredbeck deleted the remove_deprecated_model_methods branch September 9, 2016 02:11
@batter
Copy link
Collaborator

batter commented Oct 17, 2016

@jaredbeck - This should warrant a major version bump as per semantic versioning, since it makes an non backwards compatible API change, correct?

@batter batter added this to the 6.0.0 milestone Oct 17, 2016
@jaredbeck
Copy link
Member Author

@jaredbeck - This should warrant a major version bump as per semantic versioning, since it makes an non backwards compatible API change, correct?

Absolutely, positively, yes sir. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants