Add cards and badges #13
Conversation
src/badges.less
Outdated
| text-align: center; | ||
| white-space: nowrap; | ||
| vertical-align: baseline; | ||
| background-color: #868e96; |
There was a problem hiding this comment.
Shouldnt this be assigned a colour variable?
There was a problem hiding this comment.
Yeah totally forgot about that, I'll replace it asap!
src/cards.less
Outdated
| // since we want to avoid the little blank space between | ||
| // image and border-top-left/right-radius, so we force | ||
| // the default border class and customize it on the img | ||
| .border; |
There was a problem hiding this comment.
Maybe for cards, we don't need to use the crooked borders like shown in the other elements. It could be shown as something similar to a "Note Card" which has straight lines. That way the button within it stands out more. And then we don't have to worry about adjusting the image style from the border effects.
But I like the direction so far!
There was a problem hiding this comment.
Sure, I'll fix it asap. I have to admit that the crooked borders was not very good for the cards. I'll fix that and add a box shadow like on the pic, and also add header/footer customization on cards.
|
Couple comments above for the cards (and badge color variable). But I also wanted to say that the badges look sharp. Great stuff!
|
|
I really like how the badges are and follow properly the paper theme, but if you feel they are too sharp, should I just put another border radius? How do you see the badges? |
|
I've just fixed the hard-coded color on badges and added a new one, that I think will be used especially for text (.muted, a gray and its lighten version). I also removed edgy corners on the badges, don't know if that what @rhyneav wanted. I can still change it depending on what you want.
|
|
@TotomInc sorry, I meant that they look sharp as in James Bond in a tuxedo type of sharp. I really liked how they matched the theme with the uneven borders rather than the rounded radius. What I'm trying to say is that your original badges looked great as this: |
|
Oops, sorry I misunderstand your comment on badges, I'm going to revert the changes! Also, did you check the new cards? I removed the paper-style borders and added a shadow. |
|
The PR is ready to be merged @rhyneav . |
|
Looks really good |
|
Glad you like it! 😄 |
|
Wow, cards and badges both look stellar! Thank you for doing such an awesome job with those. I also really like the addition of the muted color; much needed! |
Closes #11 to put cards and badges together. WIP on modern web components as #3 says.