More button styles #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Absolutely love it, it looks great! The click effect is a nice touch too. Also, when I merged in #13 it created a conflict in the colors.less file. Could you please resolve that file, and I'll get this merged in shortly thereafter. I also really like the functions you've been creating to generate colors. That's definitely something I need to work on more myself :) |
|
Conflict resolved |
|
Awesome, thank you! One very last thing: when you added the background color transition, it removed the shadow transition for hover so it's no longer smooth. If you could please add this back in, we should be good to rock and roll! |
|
Issue fixed |
|
Thank you again, these look great! |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the standard colour options to button and also included click transition for when the user clicks on the button