-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add !important directive on spacing #275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @s-a-tanjim apologies for the delay here! I think adding these !important
overrides like this makes a lot of sense for a library like this. It seems to be the standard across others, like Bootstrap. I'll make sure this is included in the next release!
Declaring margin|padding-small|large|none classes before would also work I believe, either way could you rebase @s-a-tanjim ? |
Rebasing was failed, so I merged and resolved conflicts. You can squash if you want @Oli8 |
Did you rebase to develop ? |
Ohh sorry, I merged with the master. My bad. You tell me what can I do |
@s-a-tanjim No worries, you should rebase you branch with papercss/develop. Basically, only your commit should be shipped in this MR. |
yello! i also ran into the problem that the spacing utilities are not |
@Oli8, The problem is develop branch is behind from the master branch. And there are some new changes in master branch. So rebasing to develop branch won't help. To reduce the complexity can you please close this PR, and there's another one you can merge: #304 |
Brief description
When we need different spacing on one side, and the class is like
margin-large margin-top-small
, themargin-top-small
needs to override themargin-large
behavior.