Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add !important directive on spacing #275

Closed
wants to merge 5 commits into from

Conversation

s-a-tanjim
Copy link

Brief description

When we need different spacing on one side, and the class is like margin-large margin-top-small, the margin-top-small needs to override the margin-large behavior.

@s-a-tanjim s-a-tanjim changed the base branch from master to develop June 11, 2022 16:46
@rhyneav rhyneav self-requested a review November 24, 2022 17:36
Copy link
Member

@rhyneav rhyneav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @s-a-tanjim apologies for the delay here! I think adding these !important overrides like this makes a lot of sense for a library like this. It seems to be the standard across others, like Bootstrap. I'll make sure this is included in the next release!

@Oli8
Copy link
Contributor

Oli8 commented May 25, 2023

Declaring margin|padding-small|large|none classes before would also work I believe, either way could you rebase @s-a-tanjim ?

@s-a-tanjim
Copy link
Author

Rebasing was failed, so I merged and resolved conflicts. You can squash if you want @Oli8

@Oli8
Copy link
Contributor

Oli8 commented May 26, 2023

Rebasing was failed, so I merged and resolved conflicts. You can squash if you want @Oli8

Did you rebase to develop ?

@s-a-tanjim
Copy link
Author

Ohh sorry, I merged with the master. My bad. You tell me what can I do

@Oli8
Copy link
Contributor

Oli8 commented May 29, 2023

Ohh sorry, I merged with the master. My bad. You tell me what can I do

@s-a-tanjim No worries, you should rebase you branch with papercss/develop. Basically, only your commit should be shipped in this MR.
Let me know if there are any problems.

@motine
Copy link

motine commented Jan 2, 2024

yello! i also ran into the problem that the spacing utilities are not important!. @rhyneav, can we merge this pull request or should i prepare something? please advise, i would love to pitch in.

@s-a-tanjim
Copy link
Author

@Oli8, The problem is develop branch is behind from the master branch. And there are some new changes in master branch. So rebasing to develop branch won't help. To reduce the complexity can you please close this PR, and there's another one you can merge: #304
(Note: If you want contributors should PR to develop branch then can you please sync that branch with master? )

@Oli8 Oli8 closed this Jan 3, 2024
@motine motine mentioned this pull request Jan 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants