Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add !important directive on spacing #304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s-a-tanjim
Copy link

@s-a-tanjim s-a-tanjim commented Jan 2, 2024

Brief description

When we need different spacing on one side, and the class is like margin-large margin-top-small, the margin-top-small needs to override the margin-large behavior.
...

Developer Certificate of Origin

Sample pictures

...

Further details

...

@Oli8
Copy link
Contributor

Oli8 commented Jan 3, 2024

I didn't understand why you couldn't make the PR to develop, anyway I'm not authorized to merge to master

@s-a-tanjim
Copy link
Author

To avoid the merge conflict.

@rhyneav
Copy link
Member

rhyneav commented Jan 5, 2024

Looks like this and #305 are similar, with the difference being that #305 includes overrides for margin-large. Would it make sense to keep the margin-large with !important like in that PR, but list those styles before margin-top-large? That way all of these utility classes can override styles but margin-top-large will still override margin-top since it's defined after?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants