New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update buttons.less #64
Conversation
Button click state for issue #63
I tried the demo but it looks like nothing change when I click or add |
Could you provide some more details and screenshots if possible in your pull request? |
@TotomInc sorry, I really forgot 'and' sign before pseudoclass :) Images of button state while on click action before commit, and after commit. It's understandable when:
expected: visual animation of click |
@Nilanno have you checked the develop branch? I think click animation has already been added on the develop branch |
See #17 |
@Fraham yes, I checked. |
Great! I see the difference. Is there a way to disable this feature if a user doesn't want the effect? |
I'm pretty sure this feature should be a general behavior, as in browsers by default, for accessibility. |
It looks really cool, it was an important feature IMO in terms of UX. Thanks for your contribution @Nilanno |
Updated base branch to develop |
Thank you @Nilanno! It looks like all buttons now have an effect when clicked. This fits well with @Fraham's click styles too. |
Button click state for issue #63