Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buttons.less #64

Merged
merged 5 commits into from Nov 23, 2017
Merged

Update buttons.less #64

merged 5 commits into from Nov 23, 2017

Conversation

AndriiKachur
Copy link
Contributor

Button click state for issue #63

@TotomInc
Copy link
Contributor

I tried the demo but it looks like nothing change when I click or add :active to a button. Did it works for you?

@afzalsayed96
Copy link
Contributor

Could you provide some more details and screenshots if possible in your pull request?

@AndriiKachur
Copy link
Contributor Author

AndriiKachur commented Nov 22, 2017

@TotomInc sorry, I really forgot 'and' sign before pseudoclass :)

Images of button state while on click action before commit, and after commit.

image
image

It's understandable when:

  1. button on a page
  2. point the cursor to the button
  3. tap trackpad on a laptop to imitate mouse click

expected: visual animation of click
current: no animation, it's not possible to understand was click action or not

@Fraham
Copy link
Contributor

Fraham commented Nov 22, 2017

@Nilanno have you checked the develop branch? I think click animation has already been added on the develop branch

@Fraham
Copy link
Contributor

Fraham commented Nov 22, 2017

See #17

@AndriiKachur
Copy link
Contributor Author

@Fraham yes, I checked.
It seems like default buttons do not have this feature.
Try to click on button here https://www.getpapercss.com/#buttons

@afzalsayed96
Copy link
Contributor

Great! I see the difference. Is there a way to disable this feature if a user doesn't want the effect?

@AndriiKachur
Copy link
Contributor Author

AndriiKachur commented Nov 23, 2017

I'm pretty sure this feature should be a general behavior, as in browsers by default, for accessibility.
So a user can turn it off by custom styles.

@rhyneav
Copy link
Member

rhyneav commented Nov 23, 2017

Here's a gif for anyone who needs it
preview

And I agree that it should be a default feature. I like the feedback of knowing the button was clicked.

I don't know if this is technically a patch though. Could you please update the base branch to develop? This would be perfect to add in v1.2.

@TotomInc
Copy link
Contributor

It looks really cool, it was an important feature IMO in terms of UX. Thanks for your contribution @Nilanno

@AndriiKachur AndriiKachur changed the base branch from master to develop November 23, 2017 15:41
@AndriiKachur
Copy link
Contributor Author

Updated base branch to develop

@rhyneav
Copy link
Member

rhyneav commented Nov 23, 2017

Thank you @Nilanno! It looks like all buttons now have an effect when clicked. This fits well with @Fraham's click styles too.

@rhyneav rhyneav merged commit 29efe4a into papercss:develop Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants