-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image/attachment upload #58
Comments
You can now manage attachments on papercups, will try to take a loos soon(ish) |
if it is ok can I take up this issue? |
Of course! |
Hey @ryg-git! How is this coming along? Need any help? |
I am sorry for taking so long, I have opened a draft PR, if you could review my code I would be grateful, also I am wondering how to handle download of the uploaded file, when user taps on message bubble with uploaded attachment,
or maybe there is even better way to handle it, let me know which could be the best way to handle this and I will try to implement it. Thank you! |
Thanks @ryg-git, I'll take a look this weekend! I think option 1 is the cleanest regarding how to handle the download. However, we could have option 1 as the default behaviour and let the user override the result by adding the What do you think? |
Yes I also think so, giving a default behaviour and let the user change it if they want different behaviour by overriding the function seems like a good idea to me too |
This will be included in the next release! |
Still WIP in the Papercups backend, therefore blocked
The text was updated successfully, but these errors were encountered: