Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image/attachment upload #58

Closed
aguilaair opened this issue Feb 21, 2021 · 8 comments · Fixed by #66
Closed

Image/attachment upload #58

aguilaair opened this issue Feb 21, 2021 · 8 comments · Fixed by #66
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Projects

Comments

@aguilaair
Copy link
Collaborator

Still WIP in the Papercups backend, therefore blocked

@aguilaair aguilaair added enhancement New feature or request good first issue Good for newcomers blocked labels Feb 21, 2021
@aguilaair aguilaair removed the blocked label Apr 16, 2021
@aguilaair
Copy link
Collaborator Author

You can now manage attachments on papercups, will try to take a loos soon(ish)
@Fiyiin do you want to take a look?

@aguilaair aguilaair added this to In progress in Roadmap Apr 21, 2021
@ryg-git
Copy link
Contributor

ryg-git commented May 3, 2021

if it is ok can I take up this issue?

@aguilaair
Copy link
Collaborator Author

Of course!

@aguilaair
Copy link
Collaborator Author

Hey @ryg-git! How is this coming along? Need any help?

@ryg-git
Copy link
Contributor

ryg-git commented May 11, 2021

I am sorry for taking so long, I have opened a draft PR, if you could review my code I would be grateful, also I am wondering how to handle download of the uploaded file, when user taps on message bubble with uploaded attachment,

  1. should we download the attachment in the default location
  2. or should we open the link in the external browser and let that browser take care of the download
  3. or we can take void Function(PapercupsMessage) onMessageBubbleTap as input paremeter in PaperCupsWidget from package user and let user handle message bubble tap.

or maybe there is even better way to handle it, let me know which could be the best way to handle this and I will try to implement it.

Thank you!

@aguilaair
Copy link
Collaborator Author

Thanks @ryg-git, I'll take a look this weekend!

I think option 1 is the cleanest regarding how to handle the download. However, we could have option 1 as the default behaviour and let the user override the result by adding the onMessageBubbleTap function.

What do you think?

@aguilaair aguilaair linked a pull request May 12, 2021 that will close this issue
@ryg-git
Copy link
Contributor

ryg-git commented May 12, 2021

Yes I also think so, giving a default behaviour and let the user change it if they want different behaviour by overriding the function seems like a good idea to me too

Roadmap automation moved this from In progress to Done May 23, 2021
aguilaair added a commit that referenced this issue May 23, 2021
@aguilaair
Copy link
Collaborator Author

This will be included in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

2 participants